Messages in this thread Patch in this message | | | From | Christophe JAILLET <> | Subject | [PATCH] zorro: Fix a resource leak in zorro7xx_remove_one() | Date | Sat, 19 Mar 2022 08:01:24 +0100 |
| |
The error handling path of the probe releases a resource that is not freed in the remove function.
In some cases, a ioremap() must be undone.
Add the missing iounmap() call in the remove function.
Fixes: 45804fbb00ee ("[SCSI] 53c700: Amiga Zorro NCR53c710 SCSI") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/scsi/zorro7xx.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/zorro7xx.c b/drivers/scsi/zorro7xx.c index 27b9e2baab1a..7acf9193a9e8 100644 --- a/drivers/scsi/zorro7xx.c +++ b/drivers/scsi/zorro7xx.c @@ -159,6 +159,8 @@ static void zorro7xx_remove_one(struct zorro_dev *z) scsi_remove_host(host); NCR_700_release(host); + if (host->base > 0x01000000) + iounmap(hostdata->base); kfree(hostdata); free_irq(host->irq, host); zorro_release_device(z); -- 2.32.0
| |