lkml.org 
[lkml]   [2022]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] csky: Move to generic ticket-spinlock
    Hi Arnd,

    On Fri, Mar 18, 2022 at 6:58 PM Arnd Bergmann <arnd@arndb.de> wrote:
    >
    > On Fri, Mar 18, 2022 at 9:34 AM <guoren@kernel.org> wrote:
    > > @@ -3,6 +3,8 @@ generic-y += asm-offsets.h
    > > generic-y += extable.h
    > > generic-y += gpio.h
    > > generic-y += kvm_para.h
    > > +generic-y += ticket-lock.h
    > > +generic-y += ticket-lock-types.h
    > > generic-y += qrwlock.h
    > > generic-y += user.h
    > > generic-y += vmlinux.lds.h
    >
    > If these headers are not included from architecture-independent code,
    > they should
    > not be marked as generic-y, same as for the qrwlock.h header
    >
    > > +#include <asm/ticket-lock.h>
    > > #include <asm/qrwlock.h>
    > >
    > > ...
    > > +#include <asm/ticket-lock-types.h>
    > > #include <asm-generic/qrwlock_types.h>
    > >
    >
    > So these should all become
    >
    > #include <asm-generic/...h>
    >
    > It would however make sense to have the trivial two-line version
    > of the two header files and put them into asm-generic/spinlock.h
    > and asm-generic/spinlock-types.h, replacing the current version.
    >
    > If you do that, then you need a 'generic-y' line for spinlock.h,
    > but not for the other ones.
    Thx for the suggestion, I've sent V2 based on Palmer's series to make
    the ticket spinlock more generic.
    Please have a look:
    https://lore.kernel.org/linux-arch/20220319035457.2214979-1-guoren@kernel.org/T/#t

    >
    > Arnd




    --
    Best Regards
    Guo Ren

    ML: https://lore.kernel.org/linux-csky/

    \
     
     \ /
      Last update: 2022-03-19 05:01    [W:3.179 / U:1.444 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site