Messages in this thread | | | Date | Sat, 19 Mar 2022 16:53:30 +0100 | From | Marc Kleine-Budde <> | Subject | Re: [PATCH] can: mcp251xfd: return errors from mcp251xfd_register_get_dev_id |
| |
On 19.03.2022 08:31:28, trix@redhat.com wrote: > From: Tom Rix <trix@redhat.com> > > Clang static analysis reports this issue > mcp251xfd-core.c:1813:7: warning: The left operand > of '&' is a garbage value > FIELD_GET(MCP251XFD_REG_DEVID_ID_MASK, dev_id), > ^ ~~~~~~ > > dev_id is set in a successful call to > mcp251xfd_register_get_dev_id(). Though the status > of calls made by mcp251xfd_register_get_dev_id() > are checked and handled, their status' are not > returned. So return err. > > Fixes: 55e5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN") > Signed-off-by: Tom Rix <trix@redhat.com>
Thanks for your patch, applied to linux-can/testing.
regards, Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | [unhandled content-type:application/pgp-signature] | |