lkml.org 
[lkml]   [2022]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] can: mcp251xfd: return errors from mcp251xfd_register_get_dev_id
Date
From: Tom Rix <trix@redhat.com>

Clang static analysis reports this issue
mcp251xfd-core.c:1813:7: warning: The left operand
of '&' is a garbage value
FIELD_GET(MCP251XFD_REG_DEVID_ID_MASK, dev_id),
^ ~~~~~~

dev_id is set in a successful call to
mcp251xfd_register_get_dev_id(). Though the status
of calls made by mcp251xfd_register_get_dev_id()
are checked and handled, their status' are not
returned. So return err.

Fixes: 55e5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN")
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
index 325024be7b045..f9dd8fdba12bc 100644
--- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
+++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
@@ -1786,7 +1786,7 @@ mcp251xfd_register_get_dev_id(const struct mcp251xfd_priv *priv, u32 *dev_id,
out_kfree_buf_rx:
kfree(buf_rx);

- return 0;
+ return err;
}

#define MCP251XFD_QUIRK_ACTIVE(quirk) \
--
2.26.3
\
 
 \ /
  Last update: 2022-03-19 16:32    [W:0.035 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site