Messages in this thread | | | Date | Sat, 19 Mar 2022 15:32:34 +0100 | Subject | Re: [PATCH v2 4/8] MIPS: mscc: ocelot: fix load/save GPIO pinctrl name | From | Krzysztof Kozlowski <> |
| |
On 18/03/2022 21:25, Michael Walle wrote: > The pinctrl device tree binding will be converted to YAML format. All > the pin nodes should end with "-pins". Fix them. > > Fixes: 15324652f612 ("MIPS: dts: ocelot: describe the load/save GPIO")
There is no bug here, so no need for fix.
> Signed-off-by: Michael Walle <michael@walle.cc> > --- > arch/mips/boot/dts/mscc/ocelot_pcb120.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/boot/dts/mscc/ocelot_pcb120.dts b/arch/mips/boot/dts/mscc/ocelot_pcb120.dts > index cda6c5ff58ad..d348742c233d 100644 > --- a/arch/mips/boot/dts/mscc/ocelot_pcb120.dts > +++ b/arch/mips/boot/dts/mscc/ocelot_pcb120.dts > @@ -27,7 +27,7 @@ phy_int_pins: phy-int-pins { > function = "gpio"; > }; > > - phy_load_save_pins: phy_load_save_pins { > + phy_load_save_pins: phy-load-save-pins { > pins = "GPIO_10";
This should be squashed with previous patch or with the next one. There is no point to align names with dtschema/dt spec one by one. Make the conversion per entire board file or SoC.
Best regards, Krzysztof
| |