lkml.org 
[lkml]   [2022]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 7/8] ARM: dts: lan9662-pcb8291: fix pinctrl node name
Hi,

Am 2022-03-19 09:24, schrieb Sergei Shtylyov:
> Hello!
>
> On 3/18/22 11:25 PM, Michael Walle wrote:
>
>> The pinctrl device tree binding will be converted to YAML format. All
>> the pin nodes should end with "-pins". Fix them.
>
> It does end with "pins" already, right?

It ends with "_pins". Please note the underscore.

>> Fixes: 290deaa10c50 ("ARM: dts: add DT for lan966 SoC and 2-port board
>> pcb8291")
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>> arch/arm/boot/dts/lan966x-pcb8291.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts
>> b/arch/arm/boot/dts/lan966x-pcb8291.dts
>> index 3281af90ac6d..3c7e3a7d6f14 100644
>> --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
>> +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
>> @@ -35,7 +35,7 @@ fc3_b_pins: fcb3-spi-pins {
>> function = "fc3_b";
>> };
>>
>> - can0_b_pins: can0_b_pins {
>> + can0_b_pins: can0-b-pins {
>
> Mhm, I can't even see what is changed here... :-/

The name of the node, s/_/-/

-michael

\
 
 \ /
  Last update: 2022-03-19 12:38    [W:0.057 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site