Messages in this thread | | | Date | Fri, 18 Mar 2022 22:40:40 +0200 | From | Vladimir Oltean <> | Subject | Re: [PATCH net-next 1/2] net: dsa: mv88e6xxx: Require ops be implemented to claim STU support |
| |
On Fri, Mar 18, 2022 at 09:13:20PM +0100, Tobias Waldekranz wrote: > Simply having a physical STU table in the device doesn't do us any > good if there's no implementation of the relevant ops to access that > table. So ensure that chips that claim STU support can also talk to > the hardware. > > This fixes an issue where chips that had a their ->info->max_sid > set (due to their family membership), but no implementation (due to > their chip-specific ops struct) would fail to probe. > > Fixes: 49c98c1dc7d9 ("net: dsa: mv88e6xxx: Disentangle STU from VTU") > Reported-by: Marek Behún <kabel@kernel.org> > Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com> > ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
(with the mention that Marek's problem is probably still not solved)
> drivers/net/dsa/mv88e6xxx/chip.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/mv88e6xxx/chip.h b/drivers/net/dsa/mv88e6xxx/chip.h > index 6a0b66354e1d..5e03cfe50156 100644 > --- a/drivers/net/dsa/mv88e6xxx/chip.h > +++ b/drivers/net/dsa/mv88e6xxx/chip.h > @@ -730,7 +730,9 @@ struct mv88e6xxx_hw_stat { > > static inline bool mv88e6xxx_has_stu(struct mv88e6xxx_chip *chip) > { > - return chip->info->max_sid > 0; > + return chip->info->max_sid > 0 && > + chip->info->ops->stu_loadpurge && > + chip->info->ops->stu_getnext; > } > > static inline bool mv88e6xxx_has_pvt(struct mv88e6xxx_chip *chip) > -- > 2.25.1 >
| |