lkml.org 
[lkml]   [2022]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1 1/2] Add FAT messages to printk index
On Thu, 17 Mar 2022 at 22:33, OGAWA Hirofumi
<hirofumi@mail.parknet.co.jp> wrote:

> Looks good. I prefer removing duplication of message prefix though, not
> strong opinion.
>
> e.g.
> #define FAT_MSG_PFX "%sFAT-fs (%s): "
> printk_index_subsys_emit(FAT_MSG_PFX, level, fmt, ##args);\
> _printk(FAT_MSG_PFX "%pV\n", level, sb->s_id, &vaf);
>
> Anyway, if this is same style with others, it is ok.

I would agree that defining a macro for the prefix may be useful. It
could be a nice hint to future developers that these things are
somewhat connected.

I can follow-up with a PATCH v2 to include what you suggest.

-- jof

\
 
 \ /
  Last update: 2022-03-18 18:23    [W:0.891 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site