Messages in this thread | | | From | Alexander Lobakin <> | Subject | [PATCH v3 net-next 0/5] ice: switch: debloat packet templates code | Date | Fri, 18 Mar 2022 17:17:08 +0100 |
| |
This hunts down several places around packet templates/dummies for switch rules which are either repetitive, fragile or just not really readable code. It's a common need to add new packet templates and to review such changes as well, try to simplify both with the help of a pair macros and aliases.
bloat-o-meter is happy about that (built w/ LLVM 13):
add/remove: 0/1 grow/shrink: 1/1 up/down: 2/-1045 (-1043) Function old new delta ice_fill_adv_dummy_packet 289 291 +2 ice_adv_add_update_vsi_list 201 - -201 ice_add_adv_rule 2950 2106 -844 Total: Before=413901, After=412858, chg -0.25% add/remove: 53/52 grow/shrink: 0/0 up/down: 4660/-3988 (672) RO Data old new delta ice_dummy_pkt_profiles - 672 +672
Diffstat also looks nice, and adding new packet templates now takes less lines.
We'll probably come out with dynamic template crafting in a while, but for now let's improve what we have currently.
From v2[0]: - rebase on top of the GTP changes; - new: convert template search code to a rodata array (-1000 bytes from .text, -400 bytes from ice.ko); - collect Reviewed-by and Tested-by (Marcin, Michal).
From v1[1]: - rebase on top of the latest next-queue (to fix #3 not applying); - adjust the kdoc accordingly to the function proto changes in #3; - no functional changes.
[0] https://lore.kernel.org/netdev/20220127154009.623304-1-alexandr.lobakin@intel.com [1] https://lore.kernel.org/netdev/20220124173116.739083-1-alexandr.lobakin@intel.com
Alexander Lobakin (5): ice: switch: add and use u16[] aliases to ice_adv_lkup_elem::{h,m}_u ice: switch: unobscurify bitops loop in ice_fill_adv_dummy_packet() ice: switch: use a struct to pass packet template params ice: switch: use convenience macros to declare dummy pkt templates ice: switch: convert packet template match code to rodata
drivers/net/ethernet/intel/ice/ice_switch.c | 489 ++++++++------------ drivers/net/ethernet/intel/ice/ice_switch.h | 12 +- 2 files changed, 211 insertions(+), 290 deletions(-)
-- 2.35.1
| |