lkml.org 
[lkml]   [2022]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] drm: of: Properly try all possible cases for bridge/panel detection
    Hi Jagan,

    On Fri 18 Mar 22, 21:35, Jagan Teki wrote:
    > Hi Paul,
    >
    > On Wed, Mar 9, 2022 at 8:02 PM Paul Kocialkowski
    > <paul.kocialkowski@bootlin.com> wrote:
    > >
    > > While bridge/panel detection was initially relying on the usual
    > > port/ports-based of graph detection, it was recently changed to
    > > perform the lookup on any child node that is not port/ports
    > > instead when such a node is available, with no fallback on the
    > > usual way.
    > >
    > > This results in breaking detection when a child node is present
    > > but does not contain any panel or bridge node, even when the
    > > usual port/ports-based of graph is there.
    >
    > Can you add that pipeline example on the commit message, it gives more
    > information on specific use cases why the existing code breaks.

    Ah I just sent v2 before reading your message.

    Well I think the description says it all: the problem shows as soon as there's
    a child node to the node passed to drm_of_find_panel_or_bridge and it's really
    independent from the of graph setup in the end.

    I think Maxime put some examples on the original thread (v4 of your patch).

    Paul

    --
    Paul Kocialkowski, Bootlin
    Embedded Linux and kernel engineering
    https://bootlin.com
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2022-03-18 17:10    [W:4.162 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site