Messages in this thread | | | Date | Fri, 18 Mar 2022 14:21:32 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [RFC PATCH 07/16] debugfs: Add signed versions of debugfs_create_u32/64 helpers |
| |
On Sun, Feb 27, 2022 at 08:55:59PM +0000, Cristian Marussi wrote: > Add a few helpers to deal with signed values integers; built on existing > debugfs internal helpers as the existing unsigned functions already do. > > Make the simple_attr_write() internal helper detect the sign of the > requested set operation from the related format string: this is needed > to be able to properly parse negatively signed input strings. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > Cc: Alexander Viro <viro@zeniv.linux.org.uk> > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> > --- > Note that in the rest of the series I do NOT need the s64 WRITE/SET > operations, that required the more invasive simple_attr_write() change, > but it seemed odd to implement a get only debug_create_s32/64 API.
Let's wait to add them when we have a need for them with a in-kernel user. Otherwise I'll just end up removing them eventually when I sweep for "is this used" cleanups.
thanks,
greg k-h
| |