lkml.org 
[lkml]   [2022]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/3] usb: xhci: Remove unwanted header inclusion
On Tue, Mar 01, 2022 at 03:58:26PM +0530, Sandeep Maheswaram wrote:
> Remove the header file and forward declare struct usb_hcd.

Why?

>
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> ---
> include/linux/usb/xhci-plat.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/usb/xhci-plat.h b/include/linux/usb/xhci-plat.h
> index 906e907..576e400 100644
> --- a/include/linux/usb/xhci-plat.h
> +++ b/include/linux/usb/xhci-plat.h
> @@ -9,7 +9,8 @@
> #define _XHCI_PLAT_H
>
> #include <linux/types.h>
> -#include <linux/usb/hcd.h>
> +
> +struct usb_hcd;
>
> struct xhci_plat_priv {
> const char *firmware_name;
> --
> 2.7.4
>

Where did this come from? Is this fixing a build breakage from a
previous patch? If not, why is this needed?

confused,

greg k-h

\
 
 \ /
  Last update: 2022-03-18 13:20    [W:0.153 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site