Messages in this thread | | | Date | Fri, 18 Mar 2022 14:16:03 +0800 | From | Oliver Sang <> | Subject | Re: [fixup! EXP srcu] 7bf8d644f8: WARNING:at_kernel/rcu/srcutree.c:#process_srcu |
| |
Hi Paul,
On Thu, Mar 17, 2022 at 11:01:29AM -0700, Paul E. McKenney wrote: > On Thu, Mar 17, 2022 at 03:16:08PM +0800, Oliver Sang wrote: > > hi, Paul, > > > > On Wed, Mar 16, 2022 at 09:53:42AM -0700, Paul E. McKenney wrote: > > > > > > > > I had a feeling that the simple fix wasn't going to cut it, so thank you > > > > for finding a scenario that proves that to be the case. Fix in progress, > > > > to be folded into the original with attribution. > > > > > > OK, the attribution isn't quite there yet, but the squished-together > > > commit is here: > > > > > > ea0098f19115 ("srcu: Prevent expedited GPs and blocking readers from consuming CPU") > > > > > > Does this version behave better for you? > > > > we tested this commit, found the issue gone. > > please be noted the issue on 7bf8d644f8 is random and ~25% rate. > > so I queued to run 100 times for this new commit, which is finally clean > > according to tests. > > > > ========================================================================================= > > compiler/kconfig/rootfs/sleep/tbox_group/testcase: > > gcc-9/x86_64-rhel-8.3-func/debian-10.4-x86_64-20200603.cgz/1/vm-snb/boot > > > > commit: > > feebd043ec6b ("Revert "srcu: Avoid expedited GPs and blocking readers from consuming CPU"") > > 7bf8d644f869 ("fixup! EXP srcu: Check for too many zero-delay srcu_reschedule() calls") > > ea0098f19115 ("srcu: Prevent expedited GPs and blocking readers from consuming CPU") > > > > feebd043ec6b9eab 7bf8d644f869260f63eaaedebab ea0098f191152c7fe3db5181a2e > > ---------------- --------------------------- --------------------------- > > fail:runs %reproduction fail:runs %reproduction fail:runs > > | | | | | > > :16 25% 4:16 0% :100 dmesg.RIP:process_srcu > > :16 25% 4:16 0% :100 dmesg.WARNING:at_kernel/rcu/srcutree.c:#process_srcu > > Thank you for testing this! Tested-by?
sure!
Tested-by: kernel test robot <oliver.sang@intel.com>
(and will add this in early mail about testing if I have enough confidence in the future :) Thanks)
> Thanx, Paul
| |