Messages in this thread | | | From | Claudiu Manoil <> | Subject | RE: [PATCH] enetc: use correct format characters | Date | Thu, 17 Mar 2022 17:37:09 +0000 |
| |
> -----Original Message----- > From: Bill Wendling <morbo@google.com> > Sent: Wednesday, March 16, 2022 11:31 PM [...] > Subject: [PATCH] enetc: use correct format characters > > When compiling with -Wformat, clang emits the following warning: > > drivers/net/ethernet/freescale/enetc/enetc_mdio.c:151:22: warning: > format specifies type 'unsigned char' but the argument has type 'int' > [-Wformat] > phy_id, dev_addr, regnum); > ^~~~~~ > ./include/linux/dev_printk.h:163:47: note: expanded from macro 'dev_dbg' > dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ > ~~~ ^~~~~~~~~~~ > ./include/linux/dev_printk.h:129:34: note: expanded from macro > 'dev_printk' > _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ > ~~~ ^~~~~~~~~~~ > > The types of these arguments are unconditionally defined, so this patch > updates the format character to the correct ones for ints and unsigned ints. > > Link: ClangBuiltLinux/linux#378 > Signed-off-by: Bill Wendling <morbo@google.com>
Reviewed-by: Claudiu Manoil <claudiu.manoil@nxp.com> Fixes: ebfcb23d62ab ("enetc: Add ENETC PF level external MDIO support")
Can be also net-next material. It's up to you. Thx.
| |