lkml.org 
[lkml]   [2022]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] irqchip: Return true/false (not 1/0) from bool functions
It's my coding conventions' problem, thx for pointing out.

Acked-by: Guo Ren <guoren@kernel.org>

On Thu, Mar 17, 2022 at 11:21 AM Haowen Bai <baihaowen@meizu.com> wrote:
>
> Return boolean values ("true" or "false") instead of 1 or 0 from bool
> functions.
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> drivers/irqchip/irq-csky-apb-intc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-csky-apb-intc.c b/drivers/irqchip/irq-csky-apb-intc.c
> index d36f536..42d8a24 100644
> --- a/drivers/irqchip/irq-csky-apb-intc.c
> +++ b/drivers/irqchip/irq-csky-apb-intc.c
> @@ -136,11 +136,11 @@ static inline bool handle_irq_perbit(struct pt_regs *regs, u32 hwirq,
> u32 irq_base)
> {
> if (hwirq == 0)
> - return 0;
> + return false;
>
> generic_handle_domain_irq(root_domain, irq_base + __fls(hwirq));
>
> - return 1;
> + return true;
> }
>
> /* gx6605s 64 irqs interrupt controller */
> --
> 2.7.4
>


--
Best Regards
Guo Ren

ML: https://lore.kernel.org/linux-csky/

\
 
 \ /
  Last update: 2022-03-17 16:42    [W:0.064 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site