Messages in this thread | | | Date | Thu, 17 Mar 2022 16:26:29 +0100 | Subject | Re: [PATCH v12 2/3] dts: arm64: mt8183: add Mediatek MDP3 nodes | From | AngeloGioacchino Del Regno <> |
| |
Il 17/03/22 15:56, Moudy Ho ha scritto: > Add device nodes for Media Data Path 3 (MDP3) modules. > > Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> > --- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 108 ++++++++++++++++++++++- > 1 file changed, 107 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > index fc6ac2a46324..eaa6dac7768b 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > @@ -1389,6 +1389,79 @@ > mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0 0x1000>; > }; > > + mdp3_rdma0: mdp3_rdma0@14001000 {
Hello Moudy,
I know, this is already at v12 and I'm truly sorry for noticing this only now, but that's a bit critical to solve: you can't use underscores in node names (but you can do it in phandles).
Example:
mdp3_rdma0: mdp3_rdma0@14001000 <-- THIS IS WRONG
mdp3_rdma0: mdp3-rdma0@14001000 <--- THIS IS OK
of course, that's the same also for mdp3-rsz0@..... and the others.
Please fix this both here and in the yaml bindings in patch 1/3!
Sorry again, Angelo
| |