Messages in this thread | | | Date | Thu, 17 Mar 2022 12:19:25 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 2/2] dwarves: cus__load_files: set errno if load fails |
| |
Em Wed, Mar 16, 2022 at 10:00:57PM -0700, John Fastabend escreveu: > kkourt@ wrote: > > From: Kornilios Kourtis <kornilios@isovalent.com> > > > > This patch improves the error seen by the user by setting errno in > > cus__load_files(). Otherwise, we get a "No such file or directory" error > > which might be confusing. > > > > Before the patch, using a bogus file: > > $ ./pahole -J ./vmlinux-5.3.18-24.102-default.debug > > pahole: ./vmlinux-5.3.18-24.102-default.debug: No such file or directory > > $ ls ./vmlinux-5.3.18-24.102-default.debug > > /home/kkourt/src/hubble-fgs/vmlinux-5.3.18-24.102-default.debug > > > > After the patch: > > $ ./pahole -J ./vmlinux-5.3.18-24.102-default.debug > > pahole: ./vmlinux-5.3.18-24.102-default.debug: Unknown error -22 > > > > Which is not very helpful, but less confusing. > > > > Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com> > > --- > > With the err to -err fix Arnaldo proposed. > > Acked-by: John Fastabend <john.fastabend@gmail.com>
Thanks, did the ammendment and collected your Acked-by,
- Arnaldo
| |