Messages in this thread | | | Date | Thu, 17 Mar 2022 08:48:44 -0600 | Subject | Re: [PATCH net-next v3 3/3] net: icmp: add reasons of the skb drops to icmp protocol | From | David Ahern <> |
| |
On 3/16/22 10:05 PM, Jakub Kicinski wrote: > On Wed, 16 Mar 2022 21:35:47 -0600 David Ahern wrote: >> On 3/16/22 9:18 PM, Jakub Kicinski wrote: >>> >>> I guess this set raises the follow up question to Dave if adding >>> drop reasons to places with MIB exception stats means improving >>> the granularity or one MIB stat == one reason? >> >> There are a few examples where multiple MIB stats are bumped on a drop, >> but the reason code should always be set based on first failure. Did you >> mean something else with your question? > > I meant whether we want to differentiate between TYPE, and BROADCAST or > whatever other possible invalid protocol cases we can get here or just > dump them all into a single protocol error code.
I think a single one is a good starting point.
| |