lkml.org 
[lkml]   [2022]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/4] drivers/s390/char: Add Ultravisor io device
On Thu, Mar 17, 2022 at 12:07:58PM +0100, Steffen Eiden wrote:
> Hi greg,
>
> On 3/17/22 10:59, Greg KH wrote:
> > On Thu, Mar 17, 2022 at 09:47:06AM +0000, Steffen Eiden wrote:
> > > This patch adds a new miscdevice to expose some Ultravisor functions
> > > to userspace. Userspace can send IOCTLs to the uvdevice that will then
> > > emit a corresponding Ultravisor Call and hands the result over to
> > > userspace. The uvdevice is available if the Ultravisor Call facility is
> > > present.
> > > Userspace can call the Retrieve Attestation Measurement
> > > Ultravisor Call using IOCTLs on the uvdevice.
> > >
> > > The uvdevice will do some sanity checks first.
> > > Then, copy the request data to kernel space, build the UVCB,
> > > perform the UV call, and copy the result back to userspace.
> > >
> > > Signed-off-by: Steffen Eiden <seiden@linux.ibm.com>
> > > Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
> >
> > Do you have a pointer to the userspace code that interacts with this
> > kernel driver? That would be good to have to verify that the api here
> > is sane.
> >
> There is a userspace tool currently under development, however, not yet
> ready to be published.

Then really, this driver should not be merged until the user/kernel api
is determined to work properly, right? Why submit this now if userspace
isn't working?

thanks,

greg k-h

\
 
 \ /
  Last update: 2022-03-17 13:00    [W:0.084 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site