Messages in this thread | | | Date | Thu, 17 Mar 2022 10:13:20 +0100 | Subject | Re: [PATCH,v2] drm/panel: Fix return value check in nt35950_probe() | From | AngeloGioacchino Del Regno <> |
| |
Il 17/03/22 09:37, Lu Wei ha scritto: > In function nt35950_probe(), mipi_dsi_device_register_full() is called > to create a MIPI DSI device. If it fails, a pointer encoded with an error > will be returned, so use IS_ERR() to check the return value. Besides, use > PTR_ERR to return the actual errno. > > Fixes: 623a3531e9cf ("drm/panel: Add driver for Novatek NT35950 DSI DriverIC panels") > Signed-off-by: Lu Wei <luwei32@huawei.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Thanks!
> --- > drivers/gpu/drm/panel/panel-novatek-nt35950.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35950.c b/drivers/gpu/drm/panel/panel-novatek-nt35950.c > index 288c7fa83ecc..d252e5e56228 100644 > --- a/drivers/gpu/drm/panel/panel-novatek-nt35950.c > +++ b/drivers/gpu/drm/panel/panel-novatek-nt35950.c > @@ -579,9 +579,9 @@ static int nt35950_probe(struct mipi_dsi_device *dsi) > } > > nt->dsi[1] = mipi_dsi_device_register_full(dsi_r_host, info); > - if (!nt->dsi[1]) { > + if (IS_ERR(nt->dsi[1])) { > dev_err(dev, "Cannot get secondary DSI node\n"); > - return -ENODEV; > + return PTR_ERR(nt->dsi[1]); > } > num_dsis++; > }
| |