Messages in this thread | | | Date | Thu, 17 Mar 2022 10:18:29 +0530 | From | Manivannan Sadhasivam <> | Subject | Re: [PATCH -next] bus: mhi: ep: remove useless judgement in mhi_ep_ring_add_element |
| |
Hi,
On Thu, Mar 17, 2022 at 11:52:32AM +0800, Yu Liao wrote: > Hi Manivannan, I found that 'ret = ' has been removed. If this is intentional, > the check of 'ret' is redundant. >
That's not intentional, thanks for finding it out. I've updated the patch. Since the patches are under development, I've squashed the change with the initial patch.
Thanks, Mani
> Thanks, > > Yu > On 2022/3/17 11:31, Yu Liao wrote: > > Remove the check of 'ret' that is impossible to be non-zero. > > > > Signed-off-by: Yu Liao <liaoyu15@huawei.com> > > --- > > drivers/bus/mhi/ep/ring.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/bus/mhi/ep/ring.c b/drivers/bus/mhi/ep/ring.c > > index ac2043e71943..161505cd628f 100644 > > --- a/drivers/bus/mhi/ep/ring.c > > +++ b/drivers/bus/mhi/ep/ring.c > > @@ -131,8 +131,6 @@ int mhi_ep_ring_add_element(struct mhi_ep_ring *ring, struct mhi_ring_element *e > > > > mhi_cntrl->write_to_host(mhi_cntrl, (void __iomem *)el, ring->rbase + (old_offset * > > sizeof(*el)), sizeof(*el)); > > - if (ret < 0) > > - return ret; > > > > return 0; > > }
| |