lkml.org 
[lkml]   [2022]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] macintosh: smu: Fix warning comparing pointer to 0
Date


Le 17/03/2022 à 03:44, Haowen Bai a écrit :
> Avoid pointer type value compared with 0 to make code clear.
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>

This change is already awaiting at
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210825061838.69746-1-deng.changcheng@zte.com.cn/

Thanks
Christophe


> ---
> drivers/macintosh/smu.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/macintosh/smu.c b/drivers/macintosh/smu.c
> index a4fbc3f..d72d073 100644
> --- a/drivers/macintosh/smu.c
> +++ b/drivers/macintosh/smu.c
> @@ -1087,7 +1087,7 @@ static int smu_open(struct inode *inode, struct file *file)
> unsigned long flags;
>
> pp = kzalloc(sizeof(struct smu_private), GFP_KERNEL);
> - if (pp == 0)
> + if (!pp)
> return -ENOMEM;
> spin_lock_init(&pp->lock);
> pp->mode = smu_file_commands;
> @@ -1254,7 +1254,7 @@ static __poll_t smu_fpoll(struct file *file, poll_table *wait)
> __poll_t mask = 0;
> unsigned long flags;
>
> - if (pp == 0)
> + if (!pp)
> return 0;
>
> if (pp->mode == smu_file_commands) {
> @@ -1277,7 +1277,7 @@ static int smu_release(struct inode *inode, struct file *file)
> unsigned long flags;
> unsigned int busy;
>
> - if (pp == 0)
> + if (!pp)
> return 0;
>
> file->private_data = NULL;
\
 
 \ /
  Last update: 2022-03-17 09:47    [W:0.033 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site