lkml.org 
[lkml]   [2022]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] macintosh: via-cuda: Fix warning comparing pointer to 0
Date
Hi,

Le 17/03/2022 à 03:40, Haowen Bai a écrit :
> Avoid pointer type value compared with 0 to make code clear.

We already have this change waiting in the queue, see
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220214010558.130201-1-yang.lee@linux.alibaba.com/

Thanks
Christophe

>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> drivers/macintosh/via-cuda.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/macintosh/via-cuda.c b/drivers/macintosh/via-cuda.c
> index cd267392..05a3cd9 100644
> --- a/drivers/macintosh/via-cuda.c
> +++ b/drivers/macintosh/via-cuda.c
> @@ -236,10 +236,10 @@ int __init find_via_cuda(void)
> const u32 *reg;
> int err;
>
> - if (vias != 0)
> + if (vias)
> return 1;
> vias = of_find_node_by_name(NULL, "via-cuda");
> - if (vias == 0)
> + if (!vias)
> return 0;
>
> reg = of_get_property(vias, "reg", NULL);
> @@ -517,7 +517,7 @@ cuda_write(struct adb_request *req)
> req->reply_len = 0;
>
> spin_lock_irqsave(&cuda_lock, flags);
> - if (current_req != 0) {
> + if (current_req) {
> last_req->next = req;
> last_req = req;
> } else {
\
 
 \ /
  Last update: 2022-03-17 09:45    [W:0.097 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site