Messages in this thread | | | Date | Thu, 17 Mar 2022 08:32:34 +0100 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH] ARM: JIVE: fix return value of __setup handler |
| |
On 12/03/2022 07:36, Randy Dunlap wrote: > __setup() handlers should return 1 to obsolete_checksetup() in > init/main.c to indicate that the boot option has been handled. > A return of 0 causes the boot option/value to be listed as an Unknown > kernel parameter and added to init's (limited) argument or environment > strings. Also, error return codes don't mean anything to > obsolete_checksetup() -- only non-zero (usually 1) or zero. > So return 1 from jive_mtdset(). > > Fixes: 9db829f485c5 ("[ARM] JIVE: Initial machine support for Logitech Jive") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Ben Dooks <ben-linux@fluff.org> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Alim Akhtar <alim.akhtar@samsung.com> > Cc: Russell King <linux@armlinux.org.uk> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: patches@armlinux.org.uk > --- > KernelVersion: v5.17-rc7 > > arch/arm/mach-s3c/mach-jive.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >
It's too late for upcoming cycle, so I will pick it up after merge window.
Best regards, Krzysztof
| |