Messages in this thread | | | Date | Thu, 17 Mar 2022 13:23:12 -0700 | From | Dave Hansen <> | Subject | Re: [PATCHv6 15/30] x86/boot: Port I/O: allow to hook up alternative helpers |
| |
On 3/17/22 13:20, Dave Hansen wrote: > You keep the preprocessor away from things like > > foo.inb = bar; > > with: > > #define inb(x) pio_ops.inb(x)
... and I spotted my nonsense just as I hit send.
You could do that ^^. But you'd need to rename the 'inb' op like:
struct port_io_ops { u8 (*f_inb)(u16 port); ... };
so that you do:
#define inb(x) pio_ops.f_inb(x)
But, remember when I said I hate playing #define tricks? ;) This is one reason why.
| |