lkml.org 
[lkml]   [2022]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv6 16/30] x86/boot: Port I/O: add decompression-time support for TDX
On Thu, Mar 17, 2022 at 01:15:01PM +0100, Thomas Gleixner wrote:
> On Wed, Mar 16 2022 at 05:08, Kirill A. Shutemov wrote:
> > void early_tdx_detect(void)
> > {
> > u32 eax, sig[3];
> > @@ -23,4 +94,12 @@ void early_tdx_detect(void)
> >
> > /* Cache TDX guest feature status */
> > tdx_guest_detected = true;
> > +
> > + /* Use hypercalls instead of I/O instructions */
> > + inb = tdx_inb;
>
> Eeew. What's wrong with writing this out?
>
> pio_ops.inb = tdx_inb;
>
> So it becomes obvious what this is about?

This leads to preprocessor hell: "pio_ops.inb" is expanded to
"pio_ops.pio_ops.inb" :/

I can rename fields in struct port_io_ops to avoid conflicts, I donno.

--
Kirill A. Shutemov

\
 
 \ /
  Last update: 2022-03-17 21:18    [W:0.086 / U:3.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site