Messages in this thread | | | Date | Wed, 16 Mar 2022 19:28:06 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next] net: lantiq_etop: add stats support |
| |
On Wed, 16 Mar 2022 00:27:33 +0100 Aleksander Jan Bajkowski wrote: > This patch adds support for software packet and byte counters.
On a quick look this driver supports multiple queues, so bumping per-device stats without holding locks (on the rx side) seems racy. Plus the netdev->stats are deprecated. The "modern" way of implementing stats is to add the appropriate members to the ring / channel structure and implement .ndo_get_stats64()
| |