lkml.org 
[lkml]   [2022]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next] net: lantiq_etop: add stats support
On Wed, 16 Mar 2022 00:27:33 +0100 Aleksander Jan Bajkowski wrote:
> This patch adds support for software packet and byte counters.

On a quick look this driver supports multiple queues, so bumping
per-device stats without holding locks (on the rx side) seems racy.
Plus the netdev->stats are deprecated. The "modern" way of implementing
stats is to add the appropriate members to the ring / channel structure
and implement .ndo_get_stats64()

\
 
 \ /
  Last update: 2022-03-17 03:31    [W:0.037 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site