Messages in this thread Patch in this message | | | From | Jiapeng Chong <> | Subject | [PATCH] sched/fair: fix boolreturn.cocci warning | Date | Thu, 17 Mar 2022 09:47:40 +0800 |
| |
Return statements in functions returning bool should use true/false instead of 1/0.
./kernel/sched/fair.c:9846:9-10: WARNING: return of 0/1 in function 'imbalanced_active_balance' with return type bool.
Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- kernel/sched/fair.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 8bcc1dbc544c..bba2f9d94e53 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -9843,9 +9843,9 @@ imbalanced_active_balance(struct lb_env *env) */ if ((env->migration_type == migrate_task) && (sd->nr_balance_failed > sd->cache_nice_tries+2)) - return 1; + return true; - return 0; + return false; } static int need_active_balance(struct lb_env *env) -- 2.20.1.7.g153144c
| |