| From | Thomas Gleixner <> | Subject | Re: [PATCHv6 03/30] x86/tdx: Add __tdx_module_call() and __tdx_hypercall() helper functions | Date | Thu, 17 Mar 2022 00:43:23 +0100 |
| |
On Wed, Mar 16 2022 at 05:08, Kirill A. Shutemov wrote: > +/* > + * Wrapper for standard use of __tdx_hypercall with no output aside from > + * return code. > + */ > +static inline u64 _tdx_hypercall(u64 fn, u64 r12, u64 r13, u64 r14, u64 r15) > +{ > + struct tdx_hypercall_args args = { > + .r10 = TDX_HYPERCALL_STANDARD, > + .r11 = fn, > + .r12 = r12, > + .r13 = r13, > + .r14 = r14, > + .r15 = r15, > + }; > + > + return __tdx_hypercall(&args, 0); > +} > + > +/* Called from __tdx_hypercall() for unrecoverable failure */ > +void __tdx_hypercall_failed(void) > +{ > + panic("TDVMCALL failed. TDX module bug?"); > +} > void __init tdx_early_init(void)
Lacks a new line before tdx_early_init().
Other than that:
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
|