Messages in this thread Patch in this message | | | Date | Wed, 16 Mar 2022 21:35:24 +0100 | From | Peter Zijlstra <> | Subject | Re: sched_core_balance() releasing interrupts with pi_lock held |
| |
On Wed, Mar 16, 2022 at 05:18:40PM +0100, Sebastian Andrzej Siewior wrote:
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 33ce5cd113d8..f4675bd8f878 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -5968,6 +5967,9 @@ static bool try_steal_cookie(int this, int that) > if (p == src->core_pick || p == src->curr) > goto next; > > + if (p->migration_disabled) > + goto next; > + > if (!cpumask_test_cpu(this, &p->cpus_mask)) > goto next; > > on top my problems are gone. Let me do some testing and then I would > patch unless PeterZ does the yelling :)
The previous thing in wrong because it tries to solve the wrong thing, the above makes sense, except I would write it like so:
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 83872f95a1ea..04c05bc4062e 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -5914,7 +5914,7 @@ static bool try_steal_cookie(int this, int that) if (p == src->core_pick || p == src->curr) goto next; - if (!cpumask_test_cpu(this, &p->cpus_mask)) + if (!is_cpu_allowed(p, this)) goto next; if (p->core_occupation > dst->idle->core_occupation)
| |