lkml.org 
[lkml]   [2022]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/9] net: mlx5: eliminate anonymous module_init & module_exit
    Date
    Eliminate anonymous module_init() and module_exit(), which can lead to
    confusion or ambiguity when reading System.map, crashes/oops/bugs,
    or an initcall_debug log.

    Give each of these init and exit functions unique driver-specific
    names to eliminate the anonymous names.

    Example 1: (System.map)
    ffffffff832fc78c t init
    ffffffff832fc79e t init
    ffffffff832fc8f8 t init

    Example 2: (initcall_debug log)
    calling init+0x0/0x12 @ 1
    initcall init+0x0/0x12 returned 0 after 15 usecs
    calling init+0x0/0x60 @ 1
    initcall init+0x0/0x60 returned 0 after 2 usecs
    calling init+0x0/0x9a @ 1
    initcall init+0x0/0x9a returned 0 after 74 usecs

    Fixes: e126ba97dba9 ("mlx5: Add driver for Mellanox Connect-IB adapters")
    Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    Cc: Eli Cohen <eli@mellanox.com>
    Cc: Saeed Mahameed <saeedm@nvidia.com>
    Cc: netdev@vger.kernel.org
    Cc: Leon Romanovsky <leon@kernel.org>
    Cc: linux-rdma@vger.kernel.org
    ---
    drivers/net/ethernet/mellanox/mlx5/core/main.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    --- lnx-517-rc8.orig/drivers/net/ethernet/mellanox/mlx5/core/main.c
    +++ lnx-517-rc8/drivers/net/ethernet/mellanox/mlx5/core/main.c
    @@ -1893,7 +1893,7 @@ static void mlx5_core_verify_params(void
    }
    }

    -static int __init init(void)
    +static int __init mlx5_init(void)
    {
    int err;

    @@ -1929,7 +1929,7 @@ err_debug:
    return err;
    }

    -static void __exit cleanup(void)
    +static void __exit mlx5_cleanup(void)
    {
    mlx5e_cleanup();
    mlx5_sf_driver_unregister();
    @@ -1937,5 +1937,5 @@ static void __exit cleanup(void)
    mlx5_unregister_debugfs();
    }

    -module_init(init);
    -module_exit(cleanup);
    +module_init(mlx5_init);
    +module_exit(mlx5_cleanup);
    \
     
     \ /
      Last update: 2022-03-16 20:21    [W:7.662 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site