lkml.org 
[lkml]   [2022]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[intel-tdx:guest-rebased 120/129] drivers/acpi/svkl.c:164 acpi_svkl_init() warn: '&acpi_svkl_dev' not released on lines: 157.
tree:   https://github.com/intel/tdx.git guest-rebased
head: 6d6cab7288e23cfe0084bd1c214e3649146eb159
commit: 370c68664d53ff13dbd36847e140df02364387a5 [120/129] ACPI: Add SVKL table support
config: x86_64-randconfig-m001-20220314 (https://download.01.org/0day-ci/archive/20220316/202203162327.0MHKaQED-lkp@intel.com/config)
compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/acpi/svkl.c:164 acpi_svkl_init() warn: '&acpi_svkl_dev' not released on lines: 157.

vim +164 drivers/acpi/svkl.c

370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 140 static int __init acpi_svkl_init(void)
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 141 {
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 142 acpi_status status = AE_OK;
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 143 int ret;
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 144
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 145 ret = misc_register(&acpi_svkl_dev);
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 146 if (ret) {
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 147 pr_err("SVKL: can't misc_register on minor=%d\n",
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 148 MISC_DYNAMIC_MINOR);
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 149 return ret;
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 150 }
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 151
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 152 mutex_init(&svkl_lock);
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 153
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 154 status = acpi_get_table(ACPI_SIG_SVKL, 0, &svkl_tbl_hdr);
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 155 if (ACPI_FAILURE(status) || !svkl_tbl_hdr) {
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 156 pr_err("get table failed\n");

misc_unregister()?

370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 157 return -ENODEV;
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 158 }
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 159
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 160 dump_svkl_header();
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 161
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 162 pr_info("ACPI: SVKL module loaded\n");
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 163
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 @164 return 0;
370c68664d53ff Kuppuswamy Sathyanarayanan 2020-06-19 165 }

---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

\
 
 \ /
  Last update: 2022-03-16 16:33    [W:0.025 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site