Messages in this thread | | | Date | Wed, 16 Mar 2022 16:13:00 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH V3 0/7] x86/entry: Clean up entry code |
| |
On Wed, Mar 16, 2022 at 04:12:21PM +0100, Peter Zijlstra wrote: > On Tue, Mar 15, 2022 at 03:39:42PM +0800, Lai Jiangshan wrote: > > > Lai Jiangshan (7): > > x86/entry: Use idtentry macro for entry_INT80_compat > > x86/traps: Move pt_regs only in fixup_bad_iret() > > x86/entry: Switch the stack after error_entry() returns > > x86/entry: move PUSH_AND_CLEAR_REGS out of error_entry > > x86/entry: Move cld to the start of idtentry > > x86/entry: Don't call error_entry for XENPV > > x86/entry: Convert SWAPGS to swapgs and remove the definition of > > SWAPGS > > So AFAICT these patches are indeed correct. > > I do however worry a little bit about the I$ impact of patch 4, and > there's a few niggles, but otherwise looks good. > > I'd love for some of the other x86 people to also look at this, but a > tentative ACK on this. >
Also, I forgot to mention; they no longer apply cleanly because I sprinked ENDBR all over the place. Mostly trivial to fixup though.
| |