Messages in this thread | | | Date | Wed, 16 Mar 2022 14:16:30 +0100 | From | Kornilios Kourtis <> | Subject | Re: [PATCH] pahole: avoid segfault when parsing a problematic file |
| |
Hi Arnaldo,
Apologies for the delayed reply.
On Sat, Mar 05, 2022 at 03:49:55PM -0300, Arnaldo Carvalho de Melo wrote: > Can you break this into two patches, one for checking dwfl_getmodules() > failure and the second setting errno? > > We should try to avoid these patches that do multiple fixes, as > sometimes one of the fixes isn't really correct and we end up not being > able to use 'git revert' which should be the case when we figure out > that some previous fix wasn't correct.
Yap, makes perfect sense. I will reply to this email with the two patches momentarily.
-- Kornilios Kourtis.
| |