lkml.org 
[lkml]   [2022]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCHv3 bpf-next 12/13] selftests/bpf: Add attach test for bpf_program__attach_kprobe_multi_opts
    Date
    Adding tests for bpf_program__attach_kprobe_multi_opts function,
    that test attach with pattern, symbols and addrs.

    Signed-off-by: Jiri Olsa <jolsa@kernel.org>
    ---
    .../bpf/prog_tests/kprobe_multi_test.c | 204 +++++++++++++++++-
    1 file changed, 193 insertions(+), 11 deletions(-)

    diff --git a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
    index ded6b8c8ec05..b9876b55fc0c 100644
    --- a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
    +++ b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
    @@ -3,7 +3,7 @@
    #include "kprobe_multi.skel.h"
    #include "trace_helpers.h"

    -static void kprobe_multi_test_run(struct kprobe_multi *skel)
    +static void kprobe_multi_test_run(struct kprobe_multi *skel, bool test_return)
    {
    LIBBPF_OPTS(bpf_test_run_opts, topts);
    int err, prog_fd;
    @@ -22,14 +22,16 @@ static void kprobe_multi_test_run(struct kprobe_multi *skel)
    ASSERT_EQ(skel->bss->kprobe_test7_result, 1, "kprobe_test7_result");
    ASSERT_EQ(skel->bss->kprobe_test8_result, 1, "kprobe_test8_result");

    - ASSERT_EQ(skel->bss->kretprobe_test1_result, 1, "kretprobe_test1_result");
    - ASSERT_EQ(skel->bss->kretprobe_test2_result, 1, "kretprobe_test2_result");
    - ASSERT_EQ(skel->bss->kretprobe_test3_result, 1, "kretprobe_test3_result");
    - ASSERT_EQ(skel->bss->kretprobe_test4_result, 1, "kretprobe_test4_result");
    - ASSERT_EQ(skel->bss->kretprobe_test5_result, 1, "kretprobe_test5_result");
    - ASSERT_EQ(skel->bss->kretprobe_test6_result, 1, "kretprobe_test6_result");
    - ASSERT_EQ(skel->bss->kretprobe_test7_result, 1, "kretprobe_test7_result");
    - ASSERT_EQ(skel->bss->kretprobe_test8_result, 1, "kretprobe_test8_result");
    + if (test_return) {
    + ASSERT_EQ(skel->bss->kretprobe_test1_result, 1, "kretprobe_test1_result");
    + ASSERT_EQ(skel->bss->kretprobe_test2_result, 1, "kretprobe_test2_result");
    + ASSERT_EQ(skel->bss->kretprobe_test3_result, 1, "kretprobe_test3_result");
    + ASSERT_EQ(skel->bss->kretprobe_test4_result, 1, "kretprobe_test4_result");
    + ASSERT_EQ(skel->bss->kretprobe_test5_result, 1, "kretprobe_test5_result");
    + ASSERT_EQ(skel->bss->kretprobe_test6_result, 1, "kretprobe_test6_result");
    + ASSERT_EQ(skel->bss->kretprobe_test7_result, 1, "kretprobe_test7_result");
    + ASSERT_EQ(skel->bss->kretprobe_test8_result, 1, "kretprobe_test8_result");
    + }
    }

    static void test_skel_api(void)
    @@ -46,7 +48,7 @@ static void test_skel_api(void)
    if (!ASSERT_OK(err, "kprobe_multi__attach"))
    goto cleanup;

    - kprobe_multi_test_run(skel);
    + kprobe_multi_test_run(skel, true);

    cleanup:
    kprobe_multi__destroy(skel);
    @@ -73,7 +75,7 @@ static void test_link_api(struct bpf_link_create_opts *opts)
    if (!ASSERT_GE(link2_fd, 0, "link_fd"))
    goto cleanup;

    - kprobe_multi_test_run(skel);
    + kprobe_multi_test_run(skel, true);

    cleanup:
    if (link1_fd != -1)
    @@ -127,6 +129,178 @@ static void test_link_api_syms(void)
    test_link_api(&opts);
    }

    +static void
    +test_attach_api(const char *pattern, struct bpf_kprobe_multi_opts *opts)
    +{
    + struct bpf_link *link1 = NULL, *link2 = NULL;
    + struct kprobe_multi *skel = NULL;
    +
    + skel = kprobe_multi__open_and_load();
    + if (!ASSERT_OK_PTR(skel, "fentry_raw_skel_load"))
    + goto cleanup;
    +
    + skel->bss->pid = getpid();
    + link1 = bpf_program__attach_kprobe_multi_opts(skel->progs.test_kprobe,
    + pattern, opts);
    + if (!ASSERT_OK_PTR(link1, "bpf_program__attach_kprobe_multi_opts"))
    + goto cleanup;
    +
    + if (opts) {
    + opts->retprobe = true;
    + link2 = bpf_program__attach_kprobe_multi_opts(skel->progs.test_kretprobe,
    + pattern, opts);
    + if (!ASSERT_OK_PTR(link2, "bpf_program__attach_kprobe_multi_opts"))
    + goto cleanup;
    + }
    +
    + kprobe_multi_test_run(skel, !!opts);
    +
    +cleanup:
    + bpf_link__destroy(link2);
    + bpf_link__destroy(link1);
    + kprobe_multi__destroy(skel);
    +}
    +
    +static void test_attach_api_pattern(void)
    +{
    + LIBBPF_OPTS(bpf_kprobe_multi_opts, opts);
    +
    + test_attach_api("bpf_fentry_test*", &opts);
    + test_attach_api("bpf_fentry_test?", NULL);
    +}
    +
    +static void test_attach_api_addrs(void)
    +{
    + LIBBPF_OPTS(bpf_kprobe_multi_opts, opts);
    + unsigned long long addrs[8];
    +
    + GET_ADDR("bpf_fentry_test1", addrs[0]);
    + GET_ADDR("bpf_fentry_test2", addrs[1]);
    + GET_ADDR("bpf_fentry_test3", addrs[2]);
    + GET_ADDR("bpf_fentry_test4", addrs[3]);
    + GET_ADDR("bpf_fentry_test5", addrs[4]);
    + GET_ADDR("bpf_fentry_test6", addrs[5]);
    + GET_ADDR("bpf_fentry_test7", addrs[6]);
    + GET_ADDR("bpf_fentry_test8", addrs[7]);
    +
    + opts.addrs = (const unsigned long *) addrs;
    + opts.cnt = ARRAY_SIZE(addrs);
    + test_attach_api(NULL, &opts);
    +}
    +
    +static void test_attach_api_syms(void)
    +{
    + LIBBPF_OPTS(bpf_kprobe_multi_opts, opts);
    + const char *syms[8] = {
    + "bpf_fentry_test1",
    + "bpf_fentry_test2",
    + "bpf_fentry_test3",
    + "bpf_fentry_test4",
    + "bpf_fentry_test5",
    + "bpf_fentry_test6",
    + "bpf_fentry_test7",
    + "bpf_fentry_test8",
    + };
    +
    + opts.syms = syms;
    + opts.cnt = ARRAY_SIZE(syms);
    + test_attach_api(NULL, &opts);
    +}
    +
    +static void test_attach_api_fails(void)
    +{
    + LIBBPF_OPTS(bpf_kprobe_multi_opts, opts);
    + struct kprobe_multi *skel = NULL;
    + struct bpf_link *link = NULL;
    + unsigned long long addrs[2];
    + const char *syms[2] = {
    + "bpf_fentry_test1",
    + "bpf_fentry_test2",
    + };
    + __u64 cookies[2];
    +
    + addrs[0] = ksym_get_addr("bpf_fentry_test1");
    + addrs[1] = ksym_get_addr("bpf_fentry_test2");
    +
    + if (!ASSERT_FALSE(!addrs[0] || !addrs[1], "ksym_get_addr"))
    + goto cleanup;
    +
    + skel = kprobe_multi__open_and_load();
    + if (!ASSERT_OK_PTR(skel, "fentry_raw_skel_load"))
    + goto cleanup;
    +
    + skel->bss->pid = getpid();
    +
    + /* fail_1 - pattern and opts NULL */
    + link = bpf_program__attach_kprobe_multi_opts(skel->progs.test_kprobe,
    + NULL, NULL);
    + if (!ASSERT_ERR_PTR(link, "fail_1"))
    + goto cleanup;
    +
    + if (!ASSERT_EQ(libbpf_get_error(link), -EINVAL, "fail_1_error"))
    + goto cleanup;
    +
    + /* fail_2 - both addrs and syms set */
    + opts.addrs = (const unsigned long *) addrs;
    + opts.syms = syms;
    + opts.cnt = ARRAY_SIZE(syms);
    + opts.cookies = NULL;
    +
    + link = bpf_program__attach_kprobe_multi_opts(skel->progs.test_kprobe,
    + NULL, &opts);
    + if (!ASSERT_ERR_PTR(link, "fail_2"))
    + goto cleanup;
    +
    + if (!ASSERT_EQ(libbpf_get_error(link), -EINVAL, "fail_2_error"))
    + goto cleanup;
    +
    + /* fail_3 - pattern and addrs set */
    + opts.addrs = (const unsigned long *) addrs;
    + opts.syms = NULL;
    + opts.cnt = ARRAY_SIZE(syms);
    + opts.cookies = NULL;
    +
    + link = bpf_program__attach_kprobe_multi_opts(skel->progs.test_kprobe,
    + "ksys_*", &opts);
    + if (!ASSERT_ERR_PTR(link, "fail_3"))
    + goto cleanup;
    +
    + if (!ASSERT_EQ(libbpf_get_error(link), -EINVAL, "fail_3_error"))
    + goto cleanup;
    +
    + /* fail_4 - pattern and cnt set */
    + opts.addrs = NULL;
    + opts.syms = NULL;
    + opts.cnt = ARRAY_SIZE(syms);
    + opts.cookies = NULL;
    +
    + link = bpf_program__attach_kprobe_multi_opts(skel->progs.test_kprobe,
    + "ksys_*", &opts);
    + if (!ASSERT_ERR_PTR(link, "fail_4"))
    + goto cleanup;
    +
    + if (!ASSERT_EQ(libbpf_get_error(link), -EINVAL, "fail_4_error"))
    + goto cleanup;
    +
    + /* fail_5 - pattern and cookies */
    + opts.addrs = NULL;
    + opts.syms = NULL;
    + opts.cnt = 0;
    + opts.cookies = cookies;
    +
    + link = bpf_program__attach_kprobe_multi_opts(skel->progs.test_kprobe,
    + "ksys_*", &opts);
    + if (!ASSERT_ERR_PTR(link, "fail_5"))
    + goto cleanup;
    +
    + if (!ASSERT_EQ(libbpf_get_error(link), -EINVAL, "fail_5_error"))
    + goto cleanup;
    +
    +cleanup:
    + bpf_link__destroy(link);
    + kprobe_multi__destroy(skel);
    +}
    +
    void test_kprobe_multi_test(void)
    {
    if (!ASSERT_OK(load_kallsyms(), "load_kallsyms"))
    @@ -138,4 +312,12 @@ void test_kprobe_multi_test(void)
    test_link_api_syms();
    if (test__start_subtest("link_api_syms"))
    test_link_api_addrs();
    + if (test__start_subtest("attach_api_pattern"))
    + test_attach_api_pattern();
    + if (test__start_subtest("attach_api_addrs"))
    + test_attach_api_addrs();
    + if (test__start_subtest("attach_api_syms"))
    + test_attach_api_syms();
    + if (test__start_subtest("attach_api_fails"))
    + test_attach_api_fails();
    }
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-03-16 13:28    [W:4.230 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site