lkml.org 
[lkml]   [2022]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] block/psi: make PSI annotations of submit_bio only work for file pages
> @@ -1035,8 +1035,9 @@ void __bio_add_page(struct bio *bio, struct page *page,
> bio->bi_iter.bi_size += len;
> bio->bi_vcnt++;
>
> - if (!bio_flagged(bio, BIO_WORKINGSET) && unlikely(PageWorkingset(page)))
> - bio_set_flag(bio, BIO_WORKINGSET);
> + if (!bio_flagged(bio, BIO_WORKINGSET_FILE) &&
> + unlikely(PageWorkingset(page)) && !PageSwapBacked(page))
> + bio_set_flag(bio, BIO_WORKINGSET_FILE);

This needs to go out of the block I/O fast path, not grow even more
checks.

\
 
 \ /
  Last update: 2022-03-16 09:48    [W:0.151 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site