Messages in this thread | | | Date | Wed, 16 Mar 2022 18:51:20 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 1/1] staging: fbtft: Consider type of init sequence values in fbtft_init_display() |
| |
On Mon, Mar 14, 2022 at 06:28:41PM +0100, Greg Kroah-Hartman wrote: > On Fri, Mar 04, 2022 at 09:34:14PM +0200, Andy Shevchenko wrote:
...
> Any reason you didn't test build this?
My test build doesn't include the WERROR for this driver, so I missed the warning. Sorry for that. Now fixed.
> drivers/staging/fbtft/fbtft-core.c: In function ‘fbtft_init_display’: > drivers/staging/fbtft/fbtft-core.c:1038:48: error: passing argument 3 of ‘fbtft_dbg_hex’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] > 1038 | s16, &par->init_sequence[i + 1], j, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/staging/fbtft/fbtft.h:441:50: note: in definition of macro ‘fbtft_par_dbg_hex’ > 441 | fbtft_dbg_hex(dev, sizeof(type), buf,\ > | ^~~ > drivers/staging/fbtft/fbtft-core.c:52:26: note: expected ‘void *’ but argument is of type ‘const s16 *’ {aka ‘const short int *’} > 52 | void *buf, size_t len, const char *fmt, ...) > | ~~~~~~^~~ > LD [M] drivers/staging/gdm724x/gdmulte.o > cc1: all warnings being treated as errors
-- With Best Regards, Andy Shevchenko
| |