Messages in this thread | | | Date | Wed, 16 Mar 2022 03:43:55 +0800 | From | kernel test robot <> | Subject | Re: [PATCH v2] uwb: nxp: sr1xx: UWB driver support for sr1xx series chip |
| |
Hi Manjunatha,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linux/master] [also build test WARNING on linus/master v5.17-rc8] [cannot apply to next-20220315] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Manjunatha-Venkatesh/uwb-nxp-sr1xx-UWB-driver-support-for-sr1xx-series-chip/20220315-191309 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2c271fe77d52a0555161926c232cd5bc07178b39 config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220316/202203160341.mXSIGePW-lkp@intel.com/config) compiler: arceb-elf-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/26293c243a1119c3a848e08c588e371f21aceb53 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Manjunatha-Venkatesh/uwb-nxp-sr1xx-UWB-driver-support-for-sr1xx-series-chip/20220315-191309 git checkout 26293c243a1119c3a848e08c588e371f21aceb53 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/uwb/
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/uwb/sr1xx.c:196:6: warning: no previous prototype for 'sr1xx_wait_for_irq_gpio_low' [-Wmissing-prototypes] 196 | void sr1xx_wait_for_irq_gpio_low(struct sr1xx_dev *sr1xx_dev) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/uwb/sr1xx.c:793:5: warning: no previous prototype for 'sr1xx_dev_suspend' [-Wmissing-prototypes] 793 | int sr1xx_dev_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~ >> drivers/uwb/sr1xx.c:809:5: warning: no previous prototype for 'sr1xx_dev_resume' [-Wmissing-prototypes] 809 | int sr1xx_dev_resume(struct device *dev) | ^~~~~~~~~~~~~~~~
vim +/sr1xx_wait_for_irq_gpio_low +196 drivers/uwb/sr1xx.c
189 190 /** 191 * sr1xx_wait_for_irq_gpio_low 192 * 193 * Function to wait till irq gpio goes low state 194 * 195 */ > 196 void sr1xx_wait_for_irq_gpio_low(struct sr1xx_dev *sr1xx_dev) 197 { 198 int retry_count = 0; 199 200 do { 201 udelay(10); 202 retry_count++; 203 if (retry_count == MAX_RETRY_COUNT_FOR_HANDSHAKE) { 204 dev_info(&sr1xx_dev->spi->dev, 205 "Slave not released the IRQ even after 10ms"); 206 break; 207 } 208 } while (gpio_get_value(sr1xx_dev->irq_gpio)); 209 } 210
--- 0-DAY CI Kernel Test Service https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
| |