lkml.org 
[lkml]   [2022]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] gpio: Restrict usage of gc irq members before initialization
On Tue, Mar 15, 2022 at 7:38 PM kernel test robot <lkp@intel.com> wrote:
>
> Hi Shreeya,
>
> Thank you for the patch! Yet something to improve:


> All errors (new ones prefixed by >>):
>
> drivers/gpio/gpiolib.c: In function 'gpiod_to_irq':
> >> drivers/gpio/gpiolib.c:3068:29: error: 'struct gpio_chip' has no member named 'irq'
> 3068 | if (gc->to_irq && gc->irq.gc_irq_initialized) {
> | ^~

Exactly, because this check should go under ifdeffery.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2022-03-15 19:07    [W:0.038 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site