lkml.org 
[lkml]   [2022]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] thunderbolt: Use pre-boot DMA protection on AMD systems
On Tue, Mar 15, 2022 at 11:24:55AM -0500, Mario Limonciello wrote:
> - * handled natively using IOMMU. It is enabled when IOMMU is
> - * enabled and ACPI DMAR table has DMAR_PLATFORM_OPT_IN set.
> + * handled natively using IOMMU. It is enabled when the IOMMU is
> + * enabled and either:
> + * ACPI DMAR table has DMAR_PLATFORM_OPT_IN set
> + * or
> + * ACPI IVRS table has DMA_REMAP bitset
> */
> return sprintf(buf, "%d\n",
> - iommu_present(&pci_bus_type) && dmar_platform_optin());
> + iommu_present(&pci_bus_type) &&
> + (dmar_platform_optin() || amd_ivrs_remap_support()));

Yikes. No, the thunderbot code does not have any business poking into
either dmar_platform_optin or amd_ivrs_remap_support. This needs
a proper abstration from the IOMMU code.

\
 
 \ /
  Last update: 2022-03-15 17:49    [W:0.074 / U:1.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site