Messages in this thread | | | From | Emil Velikov <> | Date | Tue, 15 Mar 2022 12:43:22 +0000 | Subject | Re: [PATCH v2 7/8] drm/virtio: Support memory shrinking |
| |
Greetings everyone,
Food for thought: Would it make sense to have the madvise ioctl as generic DRM one? Looking around - i915, msm & panfrost already have one and the virtio implementation [below] seems as generic as it gets.
On Mon, 14 Mar 2022 at 22:44, Dmitry Osipenko <dmitry.osipenko@collabora.com> wrote:
> +#define VIRTGPU_MADV_WILLNEED 0 > +#define VIRTGPU_MADV_DONTNEED 1 > +struct drm_virtgpu_madvise { > + __u32 bo_handle; > + __u32 retained; /* out, non-zero if BO can be used */ > + __u32 madv; > + __u32 pad;
This seems to be based on panfrost/msm yet names (bo_handle vs handle), layout and documentation varies. Why is that - copy/paste is cheap :-P
HTH
-Emil
| |