Messages in this thread | | | Date | Tue, 15 Mar 2022 13:32:44 +0100 | Subject | Re: [PATCH 4/5] drm: ssd130x: Reduce temporary buffer sizes | From | Javier Martinez Canillas <> |
| |
On 3/15/22 12:07, Geert Uytterhoeven wrote: > ssd130x_clear_screen() allocates a temporary buffer sized to hold one > byte per pixel, while it only needs to hold one bit per pixel. > > ssd130x_fb_blit_rect() allocates a temporary buffer sized to hold one > byte per pixel for the whole frame buffer, while it only needs to hold > one bit per pixel for the part that is to be updated. > Pass dst_pitch to drm_fb_xrgb8888_to_mono_reversed(), as we have already
Just drm_fb_xrgb8888_to_mono() since you already fixed the name in patch 1/5.
> calculated it anyway. > > Fixes: a61732e808672cfa ("drm: Add driver for Solomon SSD130x OLED displays") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > ---
Indeed. I haven't noticed that got the calculation wrong until you pointed out.
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
-- Best regards,
Javier Martinez Canillas Linux Engineering Red Hat
| |