Messages in this thread | | | From | Krasnov Arseniy Vladimirovich <> | Subject | Re: [RFC PATCH v1 1/3] af_vsock: add two new tests for SOCK_SEQPACKET | Date | Tue, 15 Mar 2022 11:00:35 +0000 |
| |
On 15.03.2022 11:42, Stefano Garzarella wrote: > Hi Arseniy, > > On Fri, Mar 11, 2022 at 10:52:36AM +0000, Krasnov Arseniy Vladimirovich wrote: >> This adds two tests: for receive timeout and reading to invalid >> buffer provided by user. I forgot to put both patches to main >> patchset. >> >> Arseniy Krasnov(2): >> >> af_vsock: SOCK_SEQPACKET receive timeout test >> af_vsock: SOCK_SEQPACKET broken buffer test >> >> tools/testing/vsock/vsock_test.c | 170 +++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 170 insertions(+) > > Thank you for these tests!
Great! Thank You
> > I left a few comments and I'm not sure about the 'broken buffer test' behavior.
Ack
> > About the series, it sounds like something is wrong with your setup, usually the cover letter is "patch" 0. In this case I would have expected: > > [0/2] af_vsock: add two new tests for SOCK_SEQPACKET > [1/2] af_vsock: SOCK_SEQPACKET receive timeout test > [2/2] af_vsock: SOCK_SEQPACKET broken buffer test
Ack
> > Are you using `git send-email` or `git publish`? >
I'm using thunderbird to send patches><, because we don't have SMTP server(exchange only).
> > When you will remove the RFC, please add `net-next` label: > [PATCH net-next 0/2], etc.. > > Thanks, > Stefano >
| |