lkml.org 
[lkml]   [2022]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip: x86/core] x86/ibt: Dont generate ENDBR in .discard.text
    The following commit has been merged into the x86/core branch of tip:

    Commit-ID: 2b6ff7dea670a4623fae1d2349806fc7f8e305d1
    Gitweb: https://git.kernel.org/tip/2b6ff7dea670a4623fae1d2349806fc7f8e305d1
    Author: Peter Zijlstra <peterz@infradead.org>
    AuthorDate: Tue, 08 Mar 2022 16:30:43 +01:00
    Committer: Peter Zijlstra <peterz@infradead.org>
    CommitterDate: Tue, 15 Mar 2022 10:32:42 +01:00

    x86/ibt: Dont generate ENDBR in .discard.text

    Having ENDBR in discarded sections can easily lead to relocations into
    discarded sections which the linkers aren't really fond of. Objtool
    also shouldn't generate them, but why tempt fate.

    Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
    Link: https://lore.kernel.org/r/20220308154319.054842742@infradead.org
    ---
    arch/x86/include/asm/setup.h | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/arch/x86/include/asm/setup.h b/arch/x86/include/asm/setup.h
    index a12458a..896e48d 100644
    --- a/arch/x86/include/asm/setup.h
    +++ b/arch/x86/include/asm/setup.h
    @@ -8,6 +8,7 @@

    #include <linux/linkage.h>
    #include <asm/page_types.h>
    +#include <asm/ibt.h>

    #ifdef __i386__

    @@ -119,7 +120,7 @@ void *extend_brk(size_t size, size_t align);
    * executable.)
    */
    #define RESERVE_BRK(name,sz) \
    - static void __section(".discard.text") __used notrace \
    + static void __section(".discard.text") __noendbr __used notrace \
    __brk_reservation_fn_##name##__(void) { \
    asm volatile ( \
    ".pushsection .brk_reservation,\"aw\",@nobits;" \
    \
     
     \ /
      Last update: 2022-03-15 11:46    [W:2.536 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site