Messages in this thread | | | Date | Tue, 15 Mar 2022 11:09:46 +0100 | Subject | Re: [PATCH linux-next] macintosh: fix warning comparing pointer to 0 | From | Christophe Leroy <> |
| |
Le 20/08/2021 à 04:34, jing yangyang a écrit : > Fix the following coccicheck warning: > > ./drivers/macintosh/windfarm_pm91.c:152:12-13:WARNING comparing pointer to 0 > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: jing yangyang <cgel.zte@gmail.com>' != 'Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>'
Please resend.
Thanks Christophe
> --- > drivers/macintosh/windfarm_pm91.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/macintosh/windfarm_pm91.c b/drivers/macintosh/windfarm_pm91.c > index 3f346af..568f8a2 100644 > --- a/drivers/macintosh/windfarm_pm91.c > +++ b/drivers/macintosh/windfarm_pm91.c > @@ -149,7 +149,7 @@ static void wf_smu_create_cpu_fans(void) > > /* First, locate the PID params in SMU SBD */ > hdr = smu_get_sdb_partition(SMU_SDB_CPUPIDDATA_ID, NULL); > - if (hdr == 0) { > + if (!hdr) { > printk(KERN_WARNING "windfarm: CPU PID fan config not found " > "max fan speed\n"); > goto fail;
| |