Messages in this thread | | | Date | Tue, 15 Mar 2022 16:36:48 +0800 | Subject | Re: [PATCH v3] coresight: core: Fix coresight device probe failure issue | From | Jinlong Mao <> |
| |
On 3/10/2022 5:10 PM, Suzuki K Poulose wrote: > Hi Jinlong > > > On 09/03/2022 14:22, Mao Jinlong wrote: >> It is possibe that probe failure issue happens when the device >> and its child_device's probe happens at the same time. >> In coresight_make_links, has_conns_grp is true for parent, but >> has_conns_grp is false for child device as has_conns_grp is set >> to true in coresight_create_conns_sysfs_group. The probe of parent >> device will fail at this condition. Add has_conns_grp check for >> child device before make the links and make the process from >> device_register to connection_create be atomic to avoid this >> probe failure issue. >> >> Suggested-by: Suzuki K Poulose <suzuki.poulose@arm.com> >> Suggested-by: Mike Leach <mike.leach@linaro.org> >> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> > > Thanks for the rework. The patch looks good to me. > > Suzuki Thanks Suzuki.
Hi Mathieu & Mike,
Could you please help to review and provide your comments for the PATCH V3 ?
Thanks Jinlong Mao
| |