Messages in this thread | | | From | Brian Geffon <> | Date | Tue, 15 Mar 2022 13:34:21 -0400 | Subject | Re: [PATCH] zram: Add a huge_idle writeback mode |
| |
On Tue, Mar 15, 2022 at 1:28 PM Matthew Wilcox <willy@infradead.org> wrote: > > On Tue, Mar 15, 2022 at 10:22:21AM -0700, Brian Geffon wrote: > > Today it's only possible to write back as a page, idle, or huge. > > A user might want to writeback pages which are huge and idle first > > as these idle pages do not require decompression and make a good > > first pass for writeback. > > We're moving towards having many different sizes of page in play, > not just PMD and PTE sizes. Is this patch actually a good idea in > a case where we have, eg, a 32kB anonymous page on a system with 4kB > pages? How should zram handle this case? What's our cut-off for > declaring a page to be "huge"? >
Huge isn't a great term IMO, but it is what it is. ZRAM_HUGE is used to identify pages which are incompressible. Since zram is a block device which presents PAGE_SIZED blocks, do these new changes which involve many different page sizes matter as that seems orthogonal to the block subsystem. Correct me if I'm misunderstanding.
Thanks Brian
| |