lkml.org 
[lkml]   [2022]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next 1/3] net: gre_demux: add skb drop reasons to gre_rcv()
On Mon, 14 Mar 2022 21:33:10 +0800 menglong8.dong@gmail.com wrote:
> + reason = SKB_DROP_REASON_NOT_SPECIFIED;
> if (!pskb_may_pull(skb, 12))
> goto drop;

REASON_HDR_TRUNC ?

> ver = skb->data[1]&0x7f;
> - if (ver >= GREPROTO_MAX)
> + if (ver >= GREPROTO_MAX) {
> + reason = SKB_DROP_REASON_GRE_VERSION;

TBH I'm still not sure what level of granularity we should be shooting
for with the reasons. I'd throw all unexpected header values into one
bucket, not go for a reason per field, per protocol. But as I'm said
I'm not sure myself, so we can keep what you have..

> goto drop;
> + }
>
> rcu_read_lock();
> proto = rcu_dereference(gre_proto[ver]);
> - if (!proto || !proto->handler)
> + if (!proto || !proto->handler) {
> + reason = SKB_DROP_REASON_GRE_NOHANDLER;

I think the ->handler check is defensive programming, there's no
protocol upstream which would leave handler NULL.

This is akin to SKB_DROP_REASON_PTYPE_ABSENT, we can reuse that or add
a new reason, but I'd think the phrasing should be kept similar.

> goto drop_unlock;
> + }
> ret = proto->handler(skb);

\
 
 \ /
  Last update: 2022-03-16 04:09    [W:0.136 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site