Messages in this thread | | | Date | Wed, 16 Mar 2022 10:48:44 +0800 | From | Shawn Guo <> | Subject | Re: [PATCH -next] irqchip/irq-qcom-mpm: fix return value check in qcom_mpm_init() |
| |
On Wed, Mar 16, 2022 at 10:51:00AM +0800, Yang Yingliang wrote: > If devm_platform_ioremap_resource() fails, it never returns > NULL, replace NULL check with IS_ERR(). > > Fixes: a6199bb514d8 ("irqchip: Add Qualcomm MPM controller driver") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/irqchip/irq-qcom-mpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-qcom-mpm.c b/drivers/irqchip/irq-qcom-mpm.c > index eea5a753618c..d30614661eea 100644 > --- a/drivers/irqchip/irq-qcom-mpm.c > +++ b/drivers/irqchip/irq-qcom-mpm.c > @@ -375,7 +375,7 @@ static int qcom_mpm_init(struct device_node *np, struct device_node *parent) > raw_spin_lock_init(&priv->lock); > > priv->base = devm_platform_ioremap_resource(pdev, 0); > - if (!priv->base) > + if (IS_ERR(priv->base))
Oops! Thanks for the fixing!
Acked-by: Shawn Guo <shawn.guo@linaro.org>
> return PTR_ERR(priv->base); > > for (i = 0; i < priv->reg_stride; i++) { > -- > 2.25.1 >
| |