Messages in this thread | | | Date | Tue, 15 Mar 2022 20:52:11 -0400 | Subject | Re: [PATCH 1/2] xen/grant-table: remove gnttab_*transfer*() functions | From | Boris Ostrovsky <> |
| |
On 3/15/22 2:10 AM, Juergen Gross wrote: > On 15.03.22 00:37, Boris Ostrovsky wrote: >> >> On 3/11/22 5:34 AM, Juergen Gross wrote: >>> All grant table operations related to the "transfer" functionality >>> are unused currently. There have been users in the old days of the >>> "Xen-o-Linux" kernel, but those didn't make it upstream. >>> >>> So remove the "transfer" related functions. >> >> >> Do we need to assert somewhere that transfer flags are not set? > > This would be an orthogonal change, right? My patch is just removing > never called functions. >
I was thinking of having this done as part of code removal (maybe as a separate patch).
> In any case I believe checking those flags is the job of the hypervisor. > If an operation is illegal due to a transfer flag being set, it needs to > be rejected at hypervisor level.
True.
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
| |